Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otlp] Update changelog / Remove OtlpExporter resource modification code #6015

Merged
merged 9 commits into from
Dec 10, 2024
Merged

[otlp] Update changelog / Remove OtlpExporter resource modification code #6015

merged 9 commits into from
Dec 10, 2024

Conversation

rajkumar-rangaraj
Copy link
Contributor

Fixes #5927
Design discussion issue #

Changes

Please provide a brief description of the changes here.

  • Updated changelog
  • Removed OtlpExporter resource modification code

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@rajkumar-rangaraj rajkumar-rangaraj requested a review from a team as a code owner December 9, 2024 20:53
@github-actions github-actions bot added the pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package label Dec 9, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (be82099) to head (3130b18).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6015      +/-   ##
==========================================
- Coverage   86.51%   86.50%   -0.02%     
==========================================
  Files         257      257              
  Lines       11699    11689      -10     
==========================================
- Hits        10121    10111      -10     
  Misses       1578     1578
Flag Coverage Δ
unittests-Project-Experimental 86.29% <100.00%> (+0.07%) ⬆️
unittests-Project-Stable 86.32% <100.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ation/Serializer/ProtobufOtlpResourceSerializer.cs 91.66% <100.00%> (+3.43%) ⬆️

... and 5 files with indirect coverage changes

alanwest
alanwest approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@CodeBlanch CodeBlanch merged commit 75a683e into open-telemetry:main Dec 10, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeBlanch CodeBlanch CodeBlanch left review comments

@Kielek Kielek Kielek left review comments

@alanwest alanwest alanwest approved these changes

Assignees
No one assigned
Labels
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol Issues related to OpenTelemetry.Exporter.OpenTelemetryProtocol NuGet package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove OtlpExporter resource modification code
4 participants
@rajkumar-rangaraj @alanwest @Kielek @CodeBlanch